arbitrary shard counts #177
Conversation
proxy/adminservice.go
Outdated
| reportStreamValue: reportStreamValue, | ||
| shardCountConfig: shardCountConfig, | ||
| lcmParameters: lcmParameters, | ||
| clusterConnection: clusterConnection, |
There was a problem hiding this comment.
ClusterConnection is a huge context to pass around (MuxManager, inbound and outbound servers and clients, now ShardManager and intraProxyManager and Send/Ack channels). Can this code be written without this back-reference?
There was a problem hiding this comment.
Refactored the structure and removed the use of ClusterConnection
develop/config/nginx.conf
Outdated
| @@ -0,0 +1,43 @@ | |||
| worker_processes 1; | |||
There was a problem hiding this comment.
Are we using nginx in this change? I don't see it being started in main.go
There was a problem hiding this comment.
It's only for local testing for multi-proxy case. I can remove it.
Move channel management and intra-proxy routing from ClusterConnection to ShardManager.
| uses: azure/setup-helm@v4.3.0 | ||
| with: | ||
| version: v3.17.3 | ||
| version: v3.19.4 |
There was a problem hiding this comment.
what is this for? do the change in a separate PR?
There was a problem hiding this comment.
This is to fix the helm error that I didn't see in main branch:
Error: plugin is installed but unusable: failed to load plugin at "/home/runner/.local/share/helm/plugins/helm-unittest.git/plugin.yaml": error unmarshaling JSON: while decoding JSON: json: unknown field "platformHooks"
Error: Process completed with exit code 1.```
| } | ||
|
|
||
| // Add debug endpoint handler | ||
| http.HandleFunc("/debug/connections", func(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
Nice stuff but prefer having a separate PR for this
| # shardCount: | ||
| # mode: "lcm" | ||
| # localShardCount: 3 | ||
| # remoteShardCount: 2 |
There was a problem hiding this comment.
can we remove comment code? we can create separate config if needed.
| history.shardUpdateMinInterval: | ||
| - value: 1s | ||
| history.ReplicationStreamSendEmptyTaskDuration: |
There was a problem hiding this comment.
what are these config for?
| ) error { | ||
|
|
||
| i.logger.Debug("InterceptStream", tag.NewAnyTag("method", info.FullMethod)) | ||
| // Skip translation for intra-proxy streams |
3 participants
What was changed
Support replication between Temporal servers with arbitrary shard counts.
Why?
Checklist
Closes
How was this tested: